Skip to content

v0.13#370

Open
rkalis wants to merge 116 commits into
masterfrom
next
Open

v0.13#370
rkalis wants to merge 116 commits into
masterfrom
next

Conversation

@rkalis
Copy link
Copy Markdown
Member

@rkalis rkalis commented Oct 9, 2025

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cashscript Ready Ready Preview, Comment May 21, 2026 10:04am

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.19815% with 145 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.28%. Comparing base (c8320cc) to head (1bbda54).

Files with missing lines Patch % Lines
packages/utils/src/artifact.ts 2.77% 21 Missing and 14 partials ⚠️
.../cashscript/src/network/ElectrumNetworkProvider.ts 15.62% 19 Missing and 8 partials ⚠️
packages/cashscript/src/transaction-utils.ts 0.00% 20 Missing and 5 partials ⚠️
packages/cashscript/src/network/errors.ts 0.00% 12 Missing ⚠️
packages/utils/src/script.ts 27.27% 8 Missing ⚠️
packages/cashscript/src/Errors.ts 50.00% 6 Missing ⚠️
packages/cashc/src/ast/AstBuilder.ts 93.65% 3 Missing and 1 partial ⚠️
packages/utils/src/data.ts 33.33% 3 Missing and 1 partial ⚠️
packages/utils/src/fingerprint.ts 83.33% 4 Missing ⚠️
packages/utils/src/source-map.ts 63.63% 3 Missing and 1 partial ⚠️
... and 8 more

❌ Your patch check has failed because the patch coverage (83.19%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   87.21%   86.28%   -0.93%     
==========================================
  Files          48       51       +3     
  Lines        3276     3902     +626     
  Branches      593      731     +138     
==========================================
+ Hits         2857     3367     +510     
- Misses        329      415      +86     
- Partials       90      120      +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rkalis added 16 commits May 5, 2026 11:43
@rkalis
Inject a locktime guard (tx.time >= tx.locktime) when needed to enfor…
a604c86 
…ce tx.locktime correctness
@rkalis
Update github action ot use Node 22
47b83ed
@rkalis
Fix bug with empty redeem script
898fbdc
@rkalis
Fix error-swallowing in Bitauth URI generation
31d6fff
@rkalis
Add token change utilities and prevent further inputs/outputs after c…
292fe23 
…hange was added
@rkalis
Update release notes for 0.13.0-next.8
7b1a5dd
@rkalis
Bump version to 0.13.0-next.8
5799980
@rkalis
Update accidentally uncommitted edits to transaction-builder.md
b5e7cdb
@rkalis
Some small fixes
f395ffb 
- Fix some oversights where P2S contracts still try to access
  contract.address
- Fix issue where successfully generated Bitauth URI is swallowed
- Add FailingMockNetworkProvider to "test" network error behaviour
- Fix failing spellcheck
@rkalis
Bump version to 0.13.0
62f9b40
@rkalis
Update fixtures after version bump & updates
cf7c37f
@rkalis
Update artifact formatting
52ee47a
@rkalis
Fix locktime guard location handling + add tests
58f2170
@rkalis
Fix locktime guard location handling with parameter checks + add tests
6e31fcf 
Also update function.body location to be accurate
@rkalis
Recompile all fixtures after function.body.location updates
7ce8de0
@rkalis
Fix flaky signature tests in libauth-template tests
efa02ba
rkalis
rkalis commented May 19, 2026
View reviewed changes
Comment thread packages/cashc/src/semantic/EnsureFinalRequireTraversal.ts Outdated
Comment thread packages/cashc/test/compiler/UnequalTypeError/bytes_size_comparison.cash
Comment thread packages/utils/src/optimisations.ts
@rkalis
Copy link
Copy Markdown
Member Author

rkalis commented May 19, 2026

We noticed that if there is only a single function parameter (and it is having its type enforced), we are adding a redundant OP_DUP and OP_DROP. See this example:

                                           /* contract ParameterCheck() {                   */
                                           /*     function spend(                           */
                                           /*         bytes8 tag,                           */
                                           /*     ) {                                       */
OP_DUP OP_SIZE OP_8 OP_EQUALVERIFY OP_DROP /*         >>> parameter type check (bytes8 tag) */
OP_SIZE OP_NIP OP_8 OP_NUMEQUAL            /*         require(tag.length == 8);             */
                                           /*     }                                         */
                                           /* }                                             */

We either fix it with a special case, or we can choose to use OP_ROLL instead of OP_PICK, which reorders the parameters on the stack.

@mr-zwets
Copy link
Copy Markdown
Member

mr-zwets commented May 19, 2026 •
edited
Loading

compiler docs are still missing the 2nd flag option

Compiler Options

interface CompilerOptions {
  enforceFunctionParameterTypes?: boolean;
}

and similarly in the release notes only has

🛠 Add compiler option to cashc (programmatic and CLI compilation) to allow for opting out of function parameter type enforcement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rkalis @mr-zwets